mortenpi commented 5 years ago

Switches Term, CSF and RelativisticOrbital over to HalfInteger. This is possibly still pretty WIP -- I got the tests to pass, but there might still be some inconsistencies.

For the HalfInteger, I rolled our own version of the type for now, since I needed to extend it and I didn't want to commit type piracy. I also e.g. changed how the constructor behaves. At some point, it would be great to commit this back upstream though.

Closes #7.

mortenpi commented 5 years ago

Shortened that one line in the test. Should be good to go now.

codecov[bot] commented 5 years ago

Codecov Report

Merging #10 into revamp will decrease coverage by 3.34%. The diff coverage is 76.59%.

@@            Coverage Diff             @@
##           revamp      #10      +/-   ##
==========================================
- Coverage   85.07%   81.72%   -3.35%     
==========================================
  Files          14       15       +1     
  Lines         516      602      +86     
==========================================
+ Hits          439      492      +53     
- Misses         77      110      +33

Impacted Files	Coverage Δ
src/allchoices.jl	`91.66% <ø> (ø)`	:arrow_up:
src/AtomicLevels.jl	`0% <0%> (ø)`	:arrow_up:
src/jj_terms.jl	`100% <100%> (ø)`	:arrow_up:
src/jj2lsj.jl	`92.3% <100%> (ø)`	:arrow_up:
src/terms.jl	`100% <100%> (ø)`	:arrow_up:
src/csfs.jl	`36.76% <100%> (-7.88%)`	:arrow_down:
src/orbitals.jl	`92.18% <40%> (-4.54%)`	:arrow_down:
src/halfinteger.jl	`73.52% <73.52%> (ø)`
src/common.jl	`66.66% <0%> (ø)`	:arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 46d45f5...892c510. Read the comment docs.

JuliaAtoms / AtomicLevels.jl

Use HalfInteger type internally #10

Codecov Report