Closed mortenpi closed 5 years ago
Merging #37 into master will increase coverage by
0.35%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #37 +/- ##
=========================================
+ Coverage 90.35% 90.7% +0.35%
=========================================
Files 15 15
Lines 736 753 +17
=========================================
+ Hits 665 683 +18
+ Misses 71 70 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/configurations.jl | 99.28% <100%> (+0.03%) |
:arrow_up: |
src/orbitals.jl | 94.33% <100%> (+0.22%) |
:arrow_up: |
src/AtomicLevels.jl | 80% <0%> (+20%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 303d1ac...7310f4a. Read the comment docs.
Fixed everything other than the MQ
naming. Good to go or would you prefer to change it?
No, we can do that later
hash(::Configuration)
makes sure that "isequal(x,y)
thereforehash(x) == hash(y)
" holds, which is important forunique
to work properly with lists of configurations..ℓ
and.j
property toRelativisticOrbital
, since these are often used.nℓ-
andnℓ
shells.