JuliaAtoms / AtomicLevels.jl

https://juliaatoms.org/AtomicLevels.jl
Other
12 stars 3 forks source link

Add GRASP CSL tests #5

Closed mortenpi closed 5 years ago

mortenpi commented 5 years ago

This is very WIP at the moment. I need to clean it up quite a bit, but I wanted to see if the tests pass on Travis too. Basically, the tests are there and work.

I will reduce the parser library a bit. I just verbatim copied the files from GRASP.jl at the moment, so there are some unnecessary functions etc. there. I will also PR some of the features that should find their way into the package itself separately once I've cleaned them up.

codecov[bot] commented 5 years ago

Codecov Report

Merging #5 into revamp will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           revamp       #5      +/-   ##
==========================================
+ Coverage      84%   84.02%   +0.02%     
==========================================
  Files          15       15              
  Lines         600      601       +1     
==========================================
+ Hits          504      505       +1     
  Misses         96       96
Impacted Files Coverage Δ
src/csfs.jl 45.61% <100%> (+0.97%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7875b23...1167d1b. Read the comment docs.

mortenpi commented 5 years ago

Lives on top of #11 now. I was able to throw away some additional parser code now. This is good to go from my side as well now.

jagot commented 5 years ago

Thanks!