search

JuliaAtoms / AtomicLevels.jl

https://juliaatoms.org/AtomicLevels.jl
Other
12 stars 3 forks source link

Use Documenter 0.25 #53

Closed mortenpi closed 4 years ago

mortenpi commented 5 years ago

Bump Documenter to the upcoming 0.24 (currently pinned to the mp/katjax branch with docs/Manifest.toml).

The LaTeX definitions can now be done in make.jl (JuliaDocs/Documenter.jl#1097), so no need to load the latex.js (which was a bit unreliable, since we were actually loading and configuring MathJax twice).

Here is a demo: https://mortenpi.eu/gsoc2019-mockups/bulma/v14/AtomicLevels/

Once merged, will fix #45.

mortenpi commented 4 years ago

There are some docs issues, but the upgrade to 0.25 looks smooth. @jagot did you figure out if we need MathJax (in other repos), or whether KaTeX is sufficient?

jagot commented 4 years ago

KaTeX is not sufficient in other repos (don't remember exactly, but I think I could not get eqrefs and such things to work), so I think our conclusion was to use MathJax everywhere, to be consistent.

What are the "docs issues"?

mortenpi commented 4 years ago

Alright, I'll change this over to MathJax then before we merge.

What are the "docs issues"?

Doctests not passing, parse included in two places, some bad at-refs. I.e. all the build warnings.

mortenpi commented 4 years ago

Alright, I'll change this over to MathJax then before we merge.

Scratch that, it already is using MathJax :laughing: So I'd say this is good to go.

jagot commented 4 years ago

Thanks!