search

JuliaAttic / CUBLAS.jl

Julia interface to CUBLAS
Other
26 stars 19 forks source link

use Defer instead of atexit #24

Open adambrewster opened 7 years ago

adambrewster commented 7 years ago

I previously proposed not closing the cublas handle in an atexit handler (#19). This PR is for the same reasons but proposes an alternate mechanism to see the handle is closed if and when desired by the user. It also partially addressed #15.

vchuravy commented 7 years ago

Defer.jl sounds definitively interesting. I am slightly wary of adding a new dependencies.

@kshyatt What do you think?

adambrewster commented 7 years ago

That's a very reasonable objection, but Defer is pure julia and only about ~100 lines of code. The downside in this particular case is less than for some other packages that you might like to depend on.