search

JuliaAttic / CUBLAS.jl

Julia interface to CUBLAS
Other
26 stars 19 forks source link

Get things working on a basic level for 0.5 and 0.6 #25

Closed kshyatt closed 7 years ago

kshyatt commented 7 years ago

Might need to do some more here...

kshyatt commented 7 years ago

The tests pass locally for me. The problem is with CUDArt.jl.

maleadt commented 7 years ago

Huh, GitHub completely botched the line numbers on my review comments. The comparison in need of an rtol are the C[:L] ≈ dL and C[:U] ≈ dU checks.

codecov-io commented 7 years ago

Codecov Report

Merging #25 into master will increase coverage by 0.7%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #25     +/-   ##
=========================================
+ Coverage   64.41%   65.11%   +0.7%     
=========================================
  Files           5        5             
  Lines         843      883     +40     
=========================================
+ Hits          543      575     +32     
- Misses        300      308      +8
Impacted Files Coverage Δ
src/CUBLAS.jl 10.71% <ø> (ø) :arrow_up:
src/libcublas.jl 0.44% <0%> (ø) :arrow_up:
src/blas.jl 94.79% <100%> (-0.38%) :arrow_down:
src/highlevel.jl 46.55% <0%> (-6.9%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 47d51e5...8415f48. Read the comment docs.

kshyatt commented 7 years ago

OK to merge?

SimonDanisch commented 7 years ago

Yay!i should check out if this works with gpuarrays now! :)

SimonDanisch commented 7 years ago

Thanks everyone!!

julia> Pkg.test("CUBLAS")
INFO: Testing CUBLAS
WARNING: could not import Base.scale into CUBLAS
Test Summary: | Pass  Total
blascopy!     |    8      8
Test Summary: | Pass  Total
scal!         |   24     24
Test Summary: | Pass  Total
dot           |   10     10
Test Summary: | Pass  Total
dotu          |   12     12
Test Summary: | Pass  Total
dotc          |   12     12
Test Summary: | Pass  Total
nrm2          |   16     16
Test Summary: | Pass  Total
asum          |   12     12
Test Summary: | Pass  Total
axpy!         |   16     16
Test Summary:   | Pass  Total
iamax and iamin |    8      8
Test Summary: | Pass  Total
gemv!         |   24     24
Test Summary: | Pass  Total
gemv          |   36     36
Test Summary: | Pass  Total
gbmv!         |   12     12
Test Summary: | Pass  Total
gbmv          |    4      4
Test Summary: | Pass  Total
symv!         |    4      4
Test Summary: | Pass  Total
symv          |    4      4
Test Summary: | Pass  Total
hemv!         |    2      2
Test Summary: | Pass  Total
hemv          |    2      2
Test Summary: | Pass  Total
sbmv!         |    4      4
Test Summary: | Pass  Total
sbmv          |    4      4
Test Summary: | Pass  Total
hbmv!         |    4      4
Test Summary: | Pass  Total
hbmv          |    4      4
Test Summary: | Pass  Total
tbmv!         |    8      8
Test Summary: | Pass  Total
tbmv          |    8      8
Test Summary: | Pass  Total
tbsv!         |    8      8
Test Summary: | Pass  Total
tbsv          |    8      8
Test Summary: | Pass  Total
trmv!         |    4      4
Test Summary: | Pass  Total
trmv          |    4      4
Test Summary: | Pass  Total
trsv!         |    4      4
Test Summary: | Pass  Total
trsv          |    4      4
Test Summary: | Pass  Total
ger!          |    4      4
Test Summary: | Pass  Total
syr!          |    4      4
Test Summary: | Pass  Total
her!          |    2      2
Test Summary: | Pass  Total
her2!         |    2      2
Test Summary: | Pass  Total
gemm!         |    8      8
Test Summary: | Pass  Total
gemm          |    8      8
Test Summary: | Pass  Total
gemm_batched! |   40     40
Test Summary: | Pass  Total
gemm_batched  |   40     40
Test Summary: | Pass  Total
symm!         |    4      4
Test Summary: | Pass  Total
symm          |    4      4
Test Summary: | Pass  Total
syrk!         |    4      4
Test Summary: | Pass  Total
syrk          |    4      4
Test Summary: | Pass  Total
herk!         |    2      2
Test Summary: | Pass  Total
herk          |    2      2
Test Summary: | Pass  Total
syr2k!        |    4      4
Test Summary: | Pass  Total
syr2k         |    4      4
Test Summary: | Pass  Total
her2k!        |    2      2
Test Summary: | Pass  Total
her2k         |    2      2
Test Summary: | Pass  Total
trmm!         |    4      4
Test Summary: | Pass  Total
trmm          |    4      4
Test Summary: | Pass  Total
trsm!         |    4      4
Test Summary: | Pass  Total
trsm          |    4      4
Test Summary: | Pass  Total
trsm_batched! |   40     40
Test Summary: | Pass  Total
trsm_batched  |   40     40
Test Summary: | Pass  Total
hemm!         |    4      4
Test Summary: | Pass  Total
hemm          |    4      4
Test Summary: | Pass  Total
geam!         |   28     28
Test Summary: | Pass  Total
geam          |    4      4
Test Summary:  | Pass  Total
getrf_batched! |  160    160
Test Summary: | Pass  Total
getrf_batched |   80     80
Test Summary: | Pass  Total
getri_batched |  120    120
Test Summary:  | Pass  Total
matinv_batched |   40     40
Test Summary:  | Pass  Total
geqrf_batched! |   40     40
Test Summary: | Pass  Total
geqrf_batched |   40     40
Test Summary: | Pass  Total
gels_batched! |   40     40
Test Summary: | Pass  Total
gels_batched  |   40     40
Test Summary: | Pass  Total
dgmm!         |   12     12
Test Summary: | Pass  Total
dgmm          |    4      4
INFO: CUBLAS tests passed

image