JuliaAttic / CUDA.jl

DEPRECATED: old Julia programming interface for CUDA
64 stars 20 forks source link

Add some docs to exported functions, fix export function `devcount` #16

Closed ranjanan closed 8 years ago

ranjanan commented 8 years ago

@tkelman Could you review this so we can merge? Thanks.

ranjanan commented 8 years ago

@tkelman I have incorporated those changes. Thanks.

ranjanan commented 8 years ago

@ViralBShah , if @tkelman doesn't have any more suggestions, can we merge this?

ViralBShah commented 8 years ago

Is this good to merge? Does it need squashing commits?

ViralBShah commented 8 years ago

I assume we need to tag a new version.

tkelman commented 8 years ago

@vchuravy okay with you? Make any edits if anything looks off, otherwise someone with commit access should do the tag so we can push it to https://github.com/JuliaGPU/CUDA.jl/releases as well

vchuravy commented 8 years ago

@timholy As far as I know CUDA.jl and CUDArt.jl have a similar goal and CUDA.jl was mostly abandoned until recently. Since you originally created CUDArt could you shortly describe how it differs and if it makes sense to have both around.

Otherwise I would suppose that we keep CUDA.jl, with a disclaimer that development moved on to CUDArt.

ViralBShah commented 8 years ago

Maybe we should retire this package then?

vchuravy commented 8 years ago

All the other CUDA packages in JuliaGPU e.g. CUBLAS... depend on CUDArt and this graph says everything: https://github.com/JuliaGPU/CUDA.jl/graphs/contributors vs https://github.com/JuliaGPU/CUDArt.jl/graphs/contributors

tkelman commented 8 years ago

Yes it certainly looks like @ranjanan has been working on the wrong one then. If CUDArt is strictly better, this one should be deprecated so it doesn't lead to confusion and misdirected effort again.

ViralBShah commented 8 years ago

I agree. I have seen occasional use of CUDA.jl in the wild too, and hence clear signalling from the JuliaGPU organization about deprecation and using CUDArt would be good.

timholy commented 8 years ago

Thanks for kicking this off, @vchuravy. It's been a while, but these are the main differences I remember:

On the flip side, I think most of @maleadt's work (and your extension of it) was based on CUDA.jl.

maleadt commented 8 years ago

CUDArt also uses the driver API for module loading and kernel execution. Maybe we should strip CUDA.jl from its high-level features, pointing users towards CUDArt.jl instead (which supersedes CUDA.jl for most almost all use cases), yet still keeping the low-level functionality available in CUDA.jl for those who really need it (CUDArt.jl, and my Julia/NVPTX runtime).

timholy commented 8 years ago

@maleadt, that sounds like a fine plan.