JuliaAttic / OldGraphs.jl

Working with graphs in Julia
Other
205 stars 81 forks source link

Implement dicts and fix shortest_path bug #225

Closed dehann closed 8 years ago

dehann commented 8 years ago

Hi, I'm using Graphs.ExVertex type and found an issue with shortest_path. Similar to issue/#137. Please find my fix for this here -- basically there was a case where shortest_path(...) wrongly assumed indexes were available.

cc @scidom @sbromberger @mlubin

codecov-io commented 8 years ago

Current coverage is 85.35% (diff: 79.48%)

Merging #225 into master will decrease coverage by 0.30%

@@             master       #225   diff @@
==========================================
  Files            24         24          
  Lines          1443       1468    +25   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1236       1253    +17   
- Misses          207        215     +8   
  Partials          0          0          

Powered by Codecov. Last update f346201...335fa19

dehann commented 8 years ago

Hi @tkelman, please see fix and new features for Graphs.jl. New features include Dictionary based data structure for GenericIncidenceList, allowing random IDs. You had also invited me as contributor to Graphs.jl a month back (I was offline), but when I accepted later the package had since been moved to JuliaArchive and the invite fell through. I will help maintain this package, so asking for contributor access please.

tkelman commented 8 years ago

Still says awaiting your response.

I'd add some tests here.

dehann commented 8 years ago

Thanks, I did try to accept before -- tried it again now, and it worked! Thanks, not sure whats different. I'll wait a bit for the tests before I merge then... Thanks!