Closed dehann closed 7 years ago
see #240
LGTM. Note that const A = B
doesn't need @compat
unless the left hand side has a type parameter, and take!
doesn't need @compat
either since it's a normal method rather than a syntax rewrite. But it doesn't hurt to call @compat
even when unnecessary.
Thanks, will do more clean-up on later.
And thanks @maxvoxel8
New release? Currently, Metis.jl is broken because of the bug fixed in this PR.
Hi @dpo , will do -- maybe just hang tight for a few days if that is okay please?
Hi, finally tagged new version in METADATA at JuliaLang/METADATA.jl#11202
Codecov Report
52.17% <ø> (-2.38%)
92.3% <ø> (+50.64%)
76.53% <ø> (ø)
93.45% <ø> (+0.06%)
80.95% <ø> (ø)
88.88% <100%> (ø)
88.4% <83.33%> (+1.44%)
98.52% <0%> (-1.48%)
0% <0%> (ø)
Continue to review full report at Codecov.