JuliaAttic / OldGraphs.jl

Working with graphs in Julia
Other
205 stars 81 forks source link

fixes for Julia 0.6, dropping support for 0.4 #241

Closed dehann closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #241 into master will increase coverage by 0.75%. The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   84.26%   85.01%   +0.75%     
==========================================
  Files          24       25       +1     
  Lines        1468     1475       +7     
==========================================
+ Hits         1237     1254      +17     
+ Misses        231      221      -10
Impacted Files Coverage Δ
src/graph_visit.jl 52.17% <ø> (-2.38%) :arrow_down:
src/concepts.jl 92.3% <ø> (+50.64%) :arrow_up:
src/common.jl 76.53% <ø> (ø) :arrow_up:
src/dijkstra_spath.jl 93.45% <ø> (+0.06%) :arrow_up:
src/prim_mst.jl 80.95% <ø> (ø) :arrow_up:
src/a_star_spath.jl 88.88% <100%> (ø) :arrow_up:
src/maximum_adjacency_visit.jl 88.4% <83.33%> (+1.44%) :arrow_up:
src/generators.jl 98.52% <0%> (-1.48%) :arrow_down:
src/show.jl 0% <0%> (ø) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ac93fd1...9c41d71. Read the comment docs.

dehann commented 7 years ago

see #240

tkelman commented 7 years ago

LGTM. Note that const A = B doesn't need @compat unless the left hand side has a type parameter, and take! doesn't need @compat either since it's a normal method rather than a syntax rewrite. But it doesn't hurt to call @compat even when unnecessary.

dehann commented 7 years ago

Thanks, will do more clean-up on later.

And thanks @maxvoxel8

dpo commented 7 years ago

New release? Currently, Metis.jl is broken because of the bug fixed in this PR.

dehann commented 7 years ago

Hi @dpo , will do -- maybe just hang tight for a few days if that is okay please?

dehann commented 7 years ago

Hi, finally tagged new version in METADATA at JuliaLang/METADATA.jl#11202