search

JuliaAudio / PortAudio.jl

PortAudio wrapper for the Julia programming language, compatible with the JuliaAudio family of packages
Other
115 stars 19 forks source link

Fix lilyplay example #106

Closed JeffFessler closed 2 years ago

JeffFessler commented 2 years ago

The existing lilyplay example would not run due to an apparently obsolete reference to maxoutchans. This PR fixes that and adds a brief comment to explain what the file does.

codecov[bot] commented 2 years ago

Codecov Report

Merging #106 (d702d4e) into master (f6cd300) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files           2        2           
  Lines         342      342           
=======================================
  Hits          334      334           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f6cd300...d702d4e. Read the comment docs.

JeffFessler commented 2 years ago

Can be closed in favor of the more comprehensive #107. I don't have any experience with Makie so I won't be any help there, sorry!

JeffFessler commented 2 years ago

BTW, the default tests include 1.4 and 1.5 (in many OS flavors). Now that 1.6 is the LTS we could save some carbon footprint by just testing (say) 1.3, 1.6, 1 and nightly if you want.