search

JuliaAudio / PortAudio.jl

PortAudio wrapper for the Julia programming language, compatible with the JuliaAudio family of packages
Other
115 stars 19 forks source link

Update readme #111

Closed bramtayl closed 2 years ago

bramtayl commented 2 years ago

Small changes to make sure everything works. I also added samplerate float conversion.

bramtayl commented 2 years ago

Closes #86

codecov[bot] commented 2 years ago

Codecov Report

Merging #111 (056e880) into master (497567e) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   97.38%   97.40%   +0.02%     
==========================================
  Files           2        2              
  Lines         344      347       +3     
==========================================
+ Hits          335      338       +3     
  Misses          9        9
Impacted Files Coverage Δ
src/PortAudio.jl 97.43% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 497567e...056e880. Read the comment docs.

JeffFessler commented 2 years ago

I made a few minor suggestions, but otherwise it LGTM.

bramtayl commented 2 years ago

Any better?

JeffFessler commented 2 years ago

Any better?

oops sorry, i didn't realize you were waiting for feedback for me. i've made a few more suggestions for your consideration. i promise not to drag it out much longer after this :)