search

JuliaAudio / PortAudio.jl

PortAudio wrapper for the Julia programming language, compatible with the JuliaAudio family of packages
Other
115 stars 19 forks source link

fixed plotting error in spectrum.jl #84

Closed jg-854 closed 3 years ago

jg-854 commented 3 years ago

The original implementation does not account for the base offset when plotting the spectrum analysing. For example, setting fmin and fmax to 100Hz and 1000Hz respectively should plot a spectrum analyser that spans from 100-1000Hz. Instead, it spans from 0-900 Hz.

I have accounted for the base offset by adding fmin to all values on the x-axis.

codecov[bot] commented 3 years ago

Codecov Report

Merging #84 (a138c8f) into master (3cd4551) will not change coverage. The diff coverage is n/a.

:exclamation: Current head a138c8f differs from pull request most recent head 817818d. Consider uploading reports for the commit 817818d to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files           2        2           
  Lines         337      337           
=======================================
  Hits          308      308           
  Misses         29       29

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3cd4551...817818d. Read the comment docs.

rob-luke commented 3 years ago

Thanks @jg-854 that's a great fix. I'll test this today on my PC as there is no continuous integration on the examples (yet).

rob-luke commented 3 years ago

Can you remove the ds store file from the Pr please