search

JuliaAudio / PortAudio.jl

PortAudio wrapper for the Julia programming language, compatible with the JuliaAudio family of packages
Other
115 stars 19 forks source link

Capturing stderr #85

Closed petres closed 3 years ago

petres commented 3 years ago

Is it necessary to capture stderr. It makes it hard to work with the REPL in VS Code:

https://github.com/julia-vscode/julia-vscode/issues/2392

Thanks!

ssfrr commented 3 years ago

the underlying portaudio library dumps error messages straight to stdout/stderr, which is pretty annoying.

Given that we're now building our own portaudio binary anyways, probably the right fix is to patch portaudio to call some error callback and supply the error message, rather than printing directly.

rob-luke commented 3 years ago

Makes sense, @petres are you able to open a PR to address this?

petres commented 3 years ago

@rob-luke PR for patching the portaudio c library? Maybe, but I even don't know where your portaudio fork is living.

ssfrr commented 3 years ago

portaudio is built as part of Julia's binary repository. The script is here:

https://github.com/JuliaPackaging/Yggdrasil/blob/master/L/libportaudio/build_tarballs.jl

If you look at line 35 you can see where the script applies a patch, this would be another similar patch.

petres commented 3 years ago

That's also upstream an issue: https://github.com/PortAudio/portaudio/issues/423 https://github.com/PortAudio/portaudio/issues/555 https://github.com/PortAudio/portaudio/issues/163 Pending 10 years, I can't afford going deeper in that. Closing it here.