search

JuliaBerry / PiCraft.jl

Manipulate Minecraft on the Raspberry Pi from Julia
https://juliaberry.github.io/PiCraft.jl/
Other
38 stars 11 forks source link

GSoC: Functions flattened #16

Closed Ellipse0934 closed 6 years ago

Ellipse0934 commented 6 years ago

All functions have been flattened and are no longer part of modules. clearEvents(), pollBlockHits(), camera module introduced.

Ellipse0934 commented 6 years ago

1) Suggestions to improve pollBlockHits() function code ? 2) Should getBlock(Tuple{Real,Real,Real}) be changed to getBlock(Tuple{Int,Int,Int}) ? Blocks are only present at integer coordinates hence if the user enters a Float it will be rounded and changed to an Int. 3) Will function names like setting(), save(), restore() conflict with anything else ? Should they be changed to something else ?

aviks commented 6 years ago

save and restore cannot be exported from this package as is. They should either be renamed, or not exported. If not exported, they can be called as PiCraft.save() .. etc.

Other than that, looks good.