search

JuliaBerry / SenseHat.jl

Julia package for the Raspberry Pi Sense HAT
Other
15 stars 12 forks source link

Update for Julia 1.0 #5

Closed Ellipse0934 closed 5 years ago

Ellipse0934 commented 5 years ago

Fix compatibility issues.

simonbyrne commented 5 years ago

Thanks. I don't have my pi set up, so I take it that this works and tests pass?

Ellipse0934 commented 5 years ago

Yes, they do. I tested everything and it works. Maybe, change to version to 0.2.0 ?

Ellipse0934 commented 5 years ago

Actually, scratch that. The pressure is being reported as -6 millibar which is clearly wrong. That one test fails and need to change using Base.Test to using Test in the test files. I have some work right now, I will fix it in a couple of hours and report when done.

simonbyrne commented 5 years ago

No worries, thanks for looking into it. I'll try to test it this weekend as well.

Ellipse0934 commented 5 years ago

Issues have been fixed. Although my pressure sensor is showing 936 millibar which is abnormally low. Since python's sense hat library is showing the same the code is correct although the test will fail.

simonbyrne commented 5 years ago

Feel free to increase the tolerance of the test: they're really to just check we're getting the correct order of magnitude.

simonbyrne commented 5 years ago

Thanks!