Closed abelsiqueira closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
90b3862
) to head (b417f6e
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This took longer than expected. The changes was simple, but the tests failed because the default formatting changed between commits. A simpler PR could be not change the template files' format, but the issue would eventually bite, so I've updated the tests to run pre-commit before comparing the resulting packages.
One thing I am not too pleased about this is that now the normal tests also require installing pre-commit.
@fdiblen, I've request your review. If you want to discuss at the office, I'll be there Thursday.
@oxinabox, let me know if you want to review as well.
I wonder if the correct play to do this more robustly, is to run JuliaFormatter on the generated files
The pre-commit
includes JuliaFormatter, so it is doing that now in the tests.
Thanks for the review!
This is the default in the Julia ecosystem, both in the official guidelines and on various styles.
The Julia files in the template have been changed to use 4 spaces. The other files in the template are still using 2 spaces. This should be changed to 4 when pre-commit is run for the first time.
Update the consistency tests that verifies Copier's API to run the pre-commit before the comparison, to ensure that formatting changes don't influence the tests.
Related issues
Closes #403
Checklist
[x] I am following the contributing guidelines
[x] Tests are passing
[x] Lint workflow is passing
[x] Docs were updated and workflow is passing
[x] CHANGELOG.md was updated