JuliaBesties / BestieTemplate.jl

Template for Julia Programming Language packages using the copier engine.
http://JuliaBesties.github.io/BestieTemplate.jl/
Mozilla Public License 2.0
48 stars 9 forks source link

Should `TestOnPR.yml` run more tests? #500

Open lucaferranti opened 2 days ago

lucaferranti commented 2 days ago

Description

In the current setup, two yaml files to run CI tests are generated

What is the rationale for this choice?

To me, would make more sense to run the whole matrix both on main and on PR. The motivation for this is that if a PR introduces an OS-dependent problem (for example, it's not rare for packages using wrappers of C-libraries to fail only on windows) I would prefer to catch this before merging the PR to main.

abelsiqueira commented 20 hours ago

This should be an option, indeed. The rationale is faster development based on the Tulipa project, where running on 1.6+Windows was taking ~2x than latest+Ubuntu. I've also had requests to run the TestOnPRs on a matrix, and let the user decide the matrix (which is a bit harder with a template, but feasible with manual intervention).