search

JuliaBooks / Books.jl

Create books with Julia
https://huijzer.xyz/Books.jl/
Other
270 stars 18 forks source link

Bump Pandoc to 2.19 #315

Closed exAClior closed 8 months ago

exAClior commented 8 months ago

Hello @rikhuijzer , we are trying to use Books.jl and would like for it to be able to build the site on Apple Silicon Machines. I did the following to make it work

  1. Bump package version of pandoc_jll , pandoc_corssref_jll, tectonic_jll.
  2. Fixed Lua script for supporting pandoc >= 2.16

Fixes #309.

rikhuijzer commented 8 months ago

Hello @rikhuijzer , we are trying to use Books.jl and would like for it to be able to build the site on Apple Silicon Machines. I did the following to make it work

1. Bump package version of `pandoc_jll` , `pandoc_corssref_jll`, `tectonic_jll`.

2. Fixed [Lua script](https://github.com/JuliaBooks/Books.jl/blob/fb37b180728af070ecb7985e47b7a59577eb81c9/src/output-block.lua#L8C1-L8C1) for supporting pandoc >= 2.16

Should resolve #309.

You are amazing, @exAClior!!! I've spent hours on trying to migrate to a newer Pandoc but gave up because I couldn't figure it out! I just tested the PDF locally and it all looks good! This is amazing!! Thanks a lot!

I've been fixing some other minor things and will merge this PR as soon as the tests pass. Then, I'll register a new version in the Julia registry.

I'll also give you push access to this repository. Feel free to work directly on this repository and to request reviews. If you want to quickly fix something then don't hesitate to wait for my review. Just merge and it should be fine 👍