JuliaCI / Appveyor.jl

Julia Appveyor script

Other

14 stars 12 forks source link

Support coverage upload #8

Closed omus closed 6 years ago

omus commented 6 years ago

Testing these changes on Mocking.jl: https://ci.appveyor.com/project/omus/mocking-jl/build/1.0.342

simonbyrne commented 6 years ago

Feel free to add more tests to this repo as well.

omus commented 6 years ago

Can you add the Codecov GitHub integration? That should be able to verify we're testing the Appveyor coverage upload with the code I added.

simonbyrne commented 6 years ago

You should have admin access now

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (version-1@9eb6f22). Click here to learn what that means. The diff coverage is 100%.

@@            Coverage Diff             @@
##             version-1     #8   +/-   ##
==========================================
  Coverage             ?   100%           
==========================================
  Files                ?      1           
  Lines                ?      1           
  Branches             ?      0           
==========================================
  Hits                 ?      1           
  Misses               ?      0           
  Partials             ?      0

Impacted Files	Coverage Δ
src/Appveyor.jl	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9eb6f22...5d668ca. Read the comment docs.

omus commented 6 years ago

PR should be good now. I added a Codecov badge to the README. Feel free to squash

omus commented 6 years ago

Noticed the code comment wasn't quite right

simonbyrne commented 6 years ago

My only concern is that it adds about 2 mins to each CI run. Is there a way to check from within Julia if codecov is enabled?

Alternatively, we could name the variable JL_CODECOV_SCRIPT (and maybe leave it commented out by default).

omus commented 6 years ago

I agree that it is problematic to add extra CI time for repos which may not need it. I think commenting it out in the README by default with a comment is the right direction. I'm not aware of a way to detect Codecov being enabled from within Julia. If it is possible I imagine it would be from within the Coverage.jl repo which takes some time to install.

omus commented 6 years ago

Alternatively, we could name the variable JL_CODECOV_SCRIPT (and maybe leave it commented out by default).

I think I'll also do this as we may want to add a JL_COVERALL_SCRIPT variable as well to the on_success step.

omus commented 6 years ago

@simonbyrne anything left to do here?

simonbyrne commented 6 years ago

Thanks!