Tag non-breaking release of BenchmarkTools.jl?

gdalle commented 7 months ago

Since the last release, there have been 3 commits that I deem possibly breaking:

https://github.com/JuliaCI/BenchmarkTools.jl/pull/309 => makes it easier to overwrite existing benchmark groups without noticing, but arguably this is a bad practice anyway
https://github.com/JuliaCI/BenchmarkTools.jl/pull/318 => more likely a bugfix
https://github.com/JuliaCI/BenchmarkTools.jl/pull/333 => removes an undocumented export so probably ok

In my view, semantic versioning is slightly looser when it comes to dev-facing packages like BenchmarkTools.jl, and so we could tag a non-breaking release. What do other people think?

gdalle commented 7 months ago

PS: I tried to maintain this package for a while but I clearly don't have the bandwidth, so once I get those changes release I'll step aside for a good long while

KristofferC commented 7 months ago

removes an https://github.com/JuliaCI/BenchmarkTools.jl/issues/332#issuecomment-1725672694 export so probably ok

Looking at https://juliahub.com/ui/Search?q=leaves&type=symbols&u=use I don't see any use of (the relevant) leaves without explicitly using BenchmarkTools prefix.

gdalle commented 7 months ago

then I propose we release 1.4.0

gdalle commented 7 months ago

doing it now since there has not been an objection

gdalle commented 7 months ago

https://github.com/JuliaRegistries/General/pull/96432

JuliaCI / BenchmarkTools.jl

Tag non-breaking release of BenchmarkTools.jl? #344