JuliaCI / Coverage.jl

Take Julia code coverage and memory allocation results, do useful things with them
MIT License
174 stars 68 forks source link

Coveralls Enterprise support #281

Closed tk3369 closed 3 years ago

tk3369 commented 4 years ago

I am trying to integrate with Coveralls Enterprise so I need to hook it up with an on-prem server. This PR adds supports for two new environment variables:

P.S. No unit test has been written as we don't currently have any for the post_request call.

fingolfin commented 3 years ago

The CI failures are fixed now. Would you mind rebasing this PR to fix the conflict and so that tests can run again? Thank you!

vtjnash commented 3 years ago

I ended up adding a COVERALLS_URL variable already in https://github.com/JuliaCI/Coverage.jl/pull/289/commits/d351511d94019a05d4003866993eeaeebf2d1fdb, as a means of submitting to a mock server (that's where it gets unit tested too). Rather than disable require_ssl_verification, I think it might make more sense to use http instead for your local server?