search

JuliaCI / Coverage.jl

Take Julia code coverage and memory allocation results, do useful things with them
MIT License
174 stars 68 forks source link

Coveralls - support PR for local submission #282

Closed tk3369 closed 3 years ago

tk3369 commented 4 years ago

Related to #281, I am doing local submission before I can hook up with a CI. And, I want the local submission to refer to a GitHub Enterprise PR.

This PR adds support for a new PULL_REQUEST environment variable. When this variable is set, it is sent to Coveralls server accordingly.

DilumAluthge commented 4 years ago

Why are tests failing?

tk3369 commented 4 years ago

I'm puzzled by the CI failure as well... It seems that it's actually making a request to coveralls.io according to the exception. Is that supposed to happen?

ERROR: LoadError: HTTP.ExceptionRequest.StatusError(422, "POST", "/api/v1/jobs", HTTP.Messages.Response:
"""
HTTP/1.1 422 Unprocessable Entity
Date: Fri, 04 Sep 2020 03:07:23 GMT
Content-Type: application/json; charset=utf-8
Content-Length: 121
Connection: keep-alive
Set-Cookie: __cfduid=d4cb392ad5bdc1a71881ca2b395d849f81599188842; expires=Sun, 04-Oct-20 03:07:22 GMT; path=/; domain=.coveralls.io; HttpOnly; SameSite=Lax
Cache-Control: no-cache
Status: 422 Unprocessable Entity
Strict-Transport-Security: max-age=15552000
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Powered-By: Phusion Passenger Enterprise 5.3.7
X-Request-Id: 3678f956-7b3d-4fa7-8533-d462a33b9c13
X-Runtime: 0.733708
X-XSS-Protection: 1; mode=block
CF-Cache-Status: DYNAMIC
cf-request-id: 04f8ae4e720000ec15a687f200000001
Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
Server: cloudflare
CF-RAY: 5cd47ff71db0ec15-ATL
{"message":"service_job_id (724002033) must be unique for Travis Jobs not supplying a Coveralls Repo Token","error":true}""")
tk3369 commented 4 years ago

Even master is failing with the same error... Is anyone familiar with the CI for this?

fingolfin commented 3 years ago

The CI failures are fixed now. Would you mind rebasing this PR to fix the conflict and so that tests can run again? Thank you!

vtjnash commented 3 years ago

I ended up implementing this as a general COVERALLS_PULL_REQUEST option, while updating all the other variables to have overrides also, in https://github.com/JuliaCI/Coverage.jl/pull/289/commits/d8c1a6ed983b3862e1b9ed4ffe4f69955f2f6f17

Sorry we forgot about this!