Closed ararslan closed 2 years ago
Merging #334 (aecec44) into master (1bc2ab4) will increase coverage by
0.52%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #334 +/- ##
==========================================
+ Coverage 90.66% 91.18% +0.52%
==========================================
Files 2 2
Lines 225 227 +2
==========================================
+ Hits 204 207 +3
+ Misses 21 20 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/codecovio.jl | 87.61% <100.00%> (+2.92%) |
:arrow_up: |
src/coveralls.jl | 94.73% <0.00%> (-1.76%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Julia 1.0 failure is because I used Sys.isfreebsd
, which was added in 1.1. Cirrus failures are a bad request:
[ Info: Submitting data to Codecov...
LoadError: HTTP.Exceptions.(, "POST, ula/4bac=acirsrdxpl_eus=3&evc=irsbid69929219&omt=ce442eef225b959872dsu=uiC/oerg.l"HTTP.Messages:"""HTTP/1.1 400 Bad Request
server: envoy
content-type: text/html; charset=utf-8
access-control-allow-headers: Origin, Content-Type, Accept, X-User-Agent
allow: GET, POST, HEAD, OPTIONS
content-length: 26
referrer-policy: same-origin
Via: 1.1 google
""")
Is this package actually still used now that most packages are using GitHub Actions for CI? Seems Codecov submission is typically handled on GHA by the official Codecov action. I wonder if I can just use the Codecov uploader with the Linux binary plus Linux emulation on Cirrus...
The answer is yes. https://github.com/ararslan/CirrusCI.jl/pull/11
Picking up from #192, as Cirrus seems now to be better supported by Codecov itself (e.g. https://community.codecov.com/t/add-support-of-uploading-from-cirrus-ci-without-token/1028/34). No idea whether it'll work now but worth another try.