search

JuliaCI / PackageEvaluator.jl

A tool to evaluate the quality of Julia packages.
http://pkg.julialang.org
MIT License
35 stars 32 forks source link

green badge if PkgEval times out and no errors so far #198

Closed bjarthur closed 6 years ago

bjarthur commented 6 years ago

we shouldn't penalize packages with extensive unit tests with a red badge. happy to work on a PR if there is a consensus.

tkelman commented 6 years ago

How do you intend to implement this?

ararslan commented 6 years ago

I don't think it's really appropriate to declare that a package is passing its tests if the tests time out before finishing. Could be that whatever caused them to time out, or anything that would run afterward, would fail.

bjarthur commented 6 years ago

how about a yellow badge then if it times out?

it seems very bad to me to discourage thorough unit testing.

Nosferican commented 6 years ago

An alternative would be to have smaller packages, test the components and just have the production ready package call them.

IainNZ commented 6 years ago

What is the package in question? How long do the tests take to run? Is that likely to change?

Adding complexity for a "timed out" is a feature request. If you'd be willing to implement such a feature, please re-open and we can discuss further. Otherwise, I suggest going the "untestable on pkgeval route".