search

JuliaCI / PkgEval.jl

Keeping tabs on the julia ecosystem
Other
28 stars 18 forks source link

Disable pkgimages. #207

Closed maleadt closed 1 year ago

maleadt commented 1 year ago

Trying this out for the next daily to assess the performance impact.

maleadt commented 1 year ago

Comparing https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/0809b18_vs_53a0a69/report.html to https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/fce9a3b_vs_1e5fdb2/report.html, it looks like we're around 20% faster disabling pkgimages. I propose we default to this; it's always possible to pass julia_args='--pkgimages=' to PkgEval.

cc @timholy @vchuravy @KristofferC

vchuravy commented 1 year ago

Is the cost purely in the precompilation stage or are you seeing slowdowns somewhere else. I am a bit uncomfortable in not testing the default experience.

maleadt commented 1 year ago

As far as I've seen, purely precompilation.

maleadt commented 1 year ago

Let's merge this for now (on the dailies there's a similar 14 -> 12h time reduction), but I hope to re-enable this soon. Mabye we can still do some performance optimizations on the Julia side, e.g., to avoid double compilation?