search

JuliaCI / PkgEval.jl

Keeping tabs on the julia ecosystem
Other
28 stars 18 forks source link

Skip `UnitfulRecipes` #263

Closed giordano closed 7 months ago

giordano commented 7 months ago

This is an old and unmaintained package (https://github.com/jw3126/UnitfulRecipes.jl/pull/81), so even if we had to fix anything in that package, nothing could be done about it. Note: this is currently failing tests in https://github.com/JuliaLang/julia/pull/53891#issuecomment-2040626771 because it's trying to install a very ancient version of GR.jl, I don't see any fix possible if the package is deprecated.

PallHaraldsson commented 7 months ago

"doesn't even work on Julia v1.9" but assuming it did on 1.0+ then it should still work? I'm ok with this since deprecated, just thinking if excluding should really be needed...

giordano commented 7 months ago

but assuming it did on 1.0+ then it should still work?

GR@0.52.0 doesn't work for me on any Julia 1.9+ on aarch64-apple-darwin, and the problem is that UnitfulRecipes is deprecated and incompatible with recent versions of Plots (and hence GR.jl), so we can't possibly get more recent versions of GR.jl. Besides the GR.jl problem, the fact is that even if we solved this problem through registry gymnastics, if we later find other bugs in UnitfulRecipes we can't fix them because it's unmaintained, so what's the point of testing it to start with?

PallHaraldsson commented 7 months ago

I'm ok with not testing (what this PR is about, PkgEval). I'm just a bit concerned why software supporting 1.0+, with dependencies (e.g. GR) all supporting 1.0+, stop working. It's not a huge priority to find out and explain... I just can see people installing and failing, and thinking Julia to blame (correctly?) and thinking PkgEval should have caught (it did...!).

If this is only on aarch64-apple-darwin I would understand (is PkgEval (also) testing there?). [Please don't waste time to get a later version to work on current Julia, because it wouldn't show older working anyway, what ideally should happen.]

t-bltg commented 6 months ago

and the problem is that UnitfulRecipes is deprecated and incompatible with recent versions of Plots

It's just that UnitfulRecipes is now integrated and maintained in Plots.jl as a package extension.

giordano commented 6 months ago

It's just that UnitfulRecipes is now integrated and maintained in Plots.jl as a package extension.

Yes, but what matters is that UnitfulRecipes itself isn't going to be touched, so testing it, finding errors and not being able to do anything about it isn't useful.