JuliaCI / PkgTemplates.jl

Create new Julia packages, the easy way
https://juliaci.github.io/PkgTemplates.jl
MIT License
635 stars 101 forks source link

Run reference tests on 1.10 instead of 1.7 #453

Closed gdalle closed 8 months ago

gdalle commented 8 months ago

How I proceeded (might be useful for future updates)

  1. change test/runtests.jl to run reference tests on v1.10.0
  2. change .github/workflows/CI.yml to ensure that v1.10.0 is part of CI
  3. go to test/reference.jl, comment out the following block and replace it with copy_file(comparison, reference)
    if PROMPT
        while true
            println("Update reference file? [y/n]")
            answer = lowercase(strip(readline()))
            if startswith(answer, "y") || startswith(answer, "n")
                # If the user chooses to update the reference file,
                # replace its contents with the comparison file.
                startswith(answer, "y") && copy_file(comparison, reference)
                break
            end
        end
    end
  1. run the tests
  2. revert the changes to test/reference.jl
gdalle commented 8 months ago

The only things that changed were CI yml files, so maybe there's a more clever way than manual updating with each new stable Julia

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bc046aa) 93.80% compared to head (3944acb) 94.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #453 +/- ## ========================================== + Coverage 93.80% 94.33% +0.53% ========================================== Files 24 24 Lines 742 742 ========================================== + Hits 696 700 +4 + Misses 46 42 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gdalle commented 8 months ago

Thanks for the review! I think we need to change the required checks before merging, which I don't have the rights to do (GitHub is still waiting on the tests to pass for 1.7.2). Could you maybe do it or grant me permission?

oxinabox commented 8 months ago

I have bumped your permissions all the way up. so you should now have them