JuliaCI / PkgTemplates.jl

Create new Julia packages, the easy way
https://juliaci.github.io/PkgTemplates.jl
MIT License
640 stars 101 forks source link

Add Documenter key and warning about SSH setup #460

Closed gdalle closed 9 months ago

gdalle commented 9 months ago

Fix #459

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6f6c392) 94.33% compared to head (34f4eea) 94.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #460 +/- ## ======================================= Coverage 94.33% 94.33% ======================================= Files 24 24 Lines 742 742 ======================================= Hits 700 700 Misses 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gdalle commented 9 months ago

Me too, but I'm not sure we can fiddle with the GitHub API, especially with secret SSH keys, and live to tell the tale

adrhill commented 9 months ago

I wish we could automate this step

Maybe a solution between just having a note in the docstring and calling the GitHub API would be to print the output of DocumenterTools.genkeys from PkgTemplates?

gdalle commented 9 months ago

It would have to be printed at the very end though cause there's lots of output. But it's a good idea, maybe open an issue to keep track?