search

JuliaCI / PkgTemplates.jl

Create new Julia packages, the easy way
https://juliaci.github.io/PkgTemplates.jl
MIT License
635 stars 101 forks source link

Allow docs/make.jl to be run from the root of the repo #465

Open MarkNahabedian opened 7 months ago

MarkNahabedian commented 7 months ago

Add the repo root to LOAD_PATH so that docs/make.jl can be run from the repo root as well as from the docs directory.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.46%. Comparing base (805bb7c) to head (c870211).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #465 +/- ## =========================================== - Coverage 94.33% 77.46% -16.88% =========================================== Files 24 24 Lines 742 741 -1 =========================================== - Hits 700 574 -126 - Misses 42 167 +125 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

oxinabox commented 7 months ago

I am not sure about this. It is one way to do it. But it's not the only way.

I am much more used to doing ] dev.. and checking in the docs/Manifest.

Or not checking in the manifest and doing that just prior to building.

gdalle commented 7 months ago

Also this changes the global Julia state following docs build which is not ideal

MarkNahabedian commented 7 months ago

My goal is that the current directory not affect the running of docs/make.jl.

I guess it might make more sense to do

cd(@__DIR__)

instead.

As for affecting global Julia state, my admittedly inelastic mind can't forsee a circumstance wehre make.jl is run from other than a stand-alone Julia session created solely for that purpose. Please enlighten me.