search

JuliaCI / PkgTemplates.jl

Create new Julia packages, the easy way
https://juliaci.github.io/PkgTemplates.jl
MIT License
635 stars 101 forks source link

Switch default version to 1.10.4 #476

Open oxinabox opened 2 months ago

oxinabox commented 2 months ago

As of a few hours ago 1.10.4 is the LTS

not sure how much this breaks in the tests. I bet it does, but i hope it doesn't Will follow up to fix those if needed

Not sure if should also update our CI setup

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.26%. Comparing base (f1c4302) to head (5ff9fe2).

Files Patch % Lines
src/template.jl 0.00% 1 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (f1c4302) and HEAD (5ff9fe2). Click for more details.

HEAD has 148 uploads less than BASE | Flag | BASE (f1c4302) | HEAD (5ff9fe2) | |------|------|------| ||152|4|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #476 +/- ## =========================================== - Coverage 94.33% 69.26% -25.08% =========================================== Files 24 24 Lines 742 615 -127 =========================================== - Hits 700 426 -274 - Misses 42 189 +147 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gdalle commented 2 months ago

Indeed 1.10 will be the LTS but it's not the case yet and it won't be as long as 1.11 hasn't been released, right?

oxinabox commented 2 months ago

idk, last time LTS was changed it was indeed not til the release after it stopped being stable. But the announcement at state of julia sounded like it was being made the LTS now.

1.11 is just around the corner anyway.