search

JuliaCI / julia-buildbot

Buildbot configuration for build.julialang.org
MIT License
19 stars 14 forks source link

Upload portable zip installer on Windows #159

Closed musm closed 4 years ago

musm commented 4 years ago

@staticfloat

I'm working on getting zip's of the Windows installer's uploaded.

My strategy is to use a python script to convert the tarballs we already generate to zip files and then upload these.

I don't know how to test this, so would love some help finalizing things. I think everything should be ok, except the FileUpload step which I haven't figured out how to get working (help here is appreciated!)

musm commented 4 years ago

Thanks for the review, incorporated all the fixes. I also squashed the commits.

musm commented 4 years ago

How do we go about finding if this all worked. The python script I confirmed correctly convert the tarballs to zip files. I'm curious about the whole infrastructure and the upload paths that I can download the zips from.

staticfloat commented 4 years ago

First, you need to add a step to upload the .zip file to AWS. Check out here: https://github.com/JuliaCI/julia-buildbot/blob/5a7c4948ef51a4957b38f2b867de101d44547344/master/builder_utils.py#L131-L133

Conditionally adding an upload of a zipfile_name would probably work.

musm commented 4 years ago

It's been hard for me to make this PR. I haven't really been able to figure out how to test things locally and run them, so I've had to massage around the code based on the existing infrastructure and I'm just hoping things work.

Would love to get another review on this.

staticfloat commented 4 years ago

Once you fix the conditional, I'll do another review, then we can test it live. ;)

musm commented 4 years ago

Thank again!!

Ok I do hope this all works now. Updated the PR!

musm commented 4 years ago

@staticfloat Should we test this out 😄 ?

staticfloat commented 4 years ago

Let's try it!