use --precompiled=no instead of deleting sys.so for coverage

JuliaCI / julia-buildbot

Buildbot configuration for build.julialang.org

MIT License

18 stars 14 forks source link

use --precompiled=no instead of deleting sys.so for coverage #21

Closed tkelman closed 9 years ago

tkelman commented 9 years ago

cc @staticfloat @kshyatt we're not currently building coverage for the release branch, so don't think we need to worry too much about compatibility here

kshyatt commented 9 years ago

Coverage is currently not working anyway due to the utf16_is_surrogate deprecation in JSON.jl that just got fixed.

tkelman commented 9 years ago

I trust that will be fixed before too long.

kshyatt commented 9 years ago

It was just fixed today. FWIW I just ran coverage on OSX with latest master with no issues.

tkelman commented 9 years ago

Did you need --output-ji ?

kshyatt commented 9 years ago

I'm honestly unsure. I've made the same changes you have here to my run_coverage.sh script and we'll see if it works!

kshyatt commented 9 years ago

:tada: Ok so not only did this work on OSX, but it removed most of the disparity between our OSX and Linux coverage runs.

staticfloat commented 9 years ago

Thanks guys!