search

JuliaCI / julia-buildbot

Buildbot configuration for build.julialang.org
MIT License
18 stars 14 forks source link

Buildbot: Specify the version number of `rr_jll` that we want to use #258

Closed DilumAluthge closed 2 years ago

DilumAluthge commented 2 years ago

cc: @Keno

Keno commented 2 years ago

Should we put the rr version in a config in the source tree instead? That way we can try out rr version bumps in a PR before enabling it on master.

DilumAluthge commented 2 years ago

That way we can try out rr version bumps in a PR before enabling it on master.

For Buildkite, we'll be able to run CI jobs on PRs made to https://github.com/JuliaCI/julia-buildkite.

DilumAluthge commented 2 years ago

LGTM, but it would be good to have build numbers at some point, because 5.5.0+0 does not work and we might run into similar situations again in the future. As is, this somewhat defeats the point if we push out a broken 5.5.0+2 or something.

https://github.com/JuliaLang/Pkg.jl/issues/1568

DilumAluthge commented 2 years ago

The workaround for now, as described in https://github.com/JuliaLang/Pkg.jl/issues/1568#issuecomment-583907586 and https://github.com/JuliaLang/Pkg.jl/issues/1568#issuecomment-583907908, is to pass the full commit hash in the rev kwarg to the PackageSpec.

DilumAluthge commented 2 years ago

If you want, we can switch this PR to use rev = "...specific commit hash...", in order to make it future-proof against e.g. a broken 5.5.0+2 in the future.

Keno commented 2 years ago

Eh, it's fine for the moment. Worst case we'll just suffer the broken CI for a bit.