search

JuliaCI / julia-buildbot

Buildbot configuration for build.julialang.org
MIT License
18 stars 14 forks source link

Only run coverage with inlining on #56

Closed yuyichao closed 7 years ago

yuyichao commented 7 years ago

Use a separate buildbot for noinline tests

Fix #55 I realized that the test list is from CoverageBase.jl so this requires https://github.com/JuliaCI/CoverageBase.jl/pull/19 @staticfloat

tkelman commented 7 years ago

can we make this run not on the ubuntu slave? there are too many nightly jobs on that builder and it gets backed up

yuyichao commented 7 years ago

I've just been copying the previous config file I touched, where should I run this then?

tkelman commented 7 years ago

centos 7 maybe? that only has the one job right now

yuyichao commented 7 years ago

Sure, is this the right way to do it?

yuyichao commented 7 years ago

I just realized that doing this will not run the tests with inliing off.

yuyichao commented 7 years ago

@tkelman @staticfloat do we actually still want to have a buildbot running noinline tests? I think it won't really be testing sth that we want to keep working (now that we don't need inlining off for coverage). I might be useful as a Fuzz test but probably not more than that.

If we still want to have no-inline tests, https://github.com/JuliaLang/julia/pull/18680 should provide an much easier way.

tkelman commented 7 years ago

I think it's worth identifying and tracking fragile tests, yes

yuyichao commented 7 years ago

In that case https://github.com/JuliaLang/julia/pull/18681....

staticfloat commented 7 years ago

It's trivial to add a second Ubuntu buildbot if that's what we need. Then tasks assigned to an Ubuntu builder will be load-balanced accordingly.

tkelman commented 7 years ago

we may want to do that anyway, but we have the centos worker and it's a bit underutilized

yuyichao commented 7 years ago

Rebased and updated the script to use the env added in https://github.com/JuliaLang/julia/pull/18680. This still launches the test process manually so that the compile test on master process also has inlining off.

@staticfloat