Closed staticfloat closed 6 years ago
I quite like this change!
On Thu, Mar 22, 2018, 21:53 Elliot Saba notifications@github.com wrote:
From this change onward, package builders will only compile and bootstrap Julia; they will not run the tests. The compiled and boostrapped binaries are uploaded to AWS under the pretesting namespace, and are then downloaded onto separate tester builders. If they pass testing within the tester_builders, the binaries are then "promoted" from pretesting to the actual download URLs.
This provides a stronger guarantee of test suite correctness, as it isolates the build environment and the testing environment somewhat, and sets the stage for e.g. cross-compiling then running tests on the actual architectures.
You can view, comment on, or merge this pull request online at:
https://github.com/JuliaCI/julia-buildbot/pull/75 Commit Summary
- Remove old builders and code, eliminate bottling
- Big overhaul! Separated testing!
File Changes
- D commands/build_bottle.sh https://github.com/JuliaCI/julia-buildbot/pull/75/files#diff-0 (58)
- D commands/cleanup_bottles.jl https://github.com/JuliaCI/julia-buildbot/pull/75/files#diff-1 (133)
- D commands/clone_homebrew.sh https://github.com/JuliaCI/julia-buildbot/pull/75/files#diff-2 (52)
- D commands/launchpad.sh https://github.com/JuliaCI/julia-buildbot/pull/75/files#diff-3 (105)
- D master/bottling.py https://github.com/JuliaCI/julia-buildbot/pull/75/files#diff-4 (84)
- M master/builder_utils.py https://github.com/JuliaCI/julia-buildbot/pull/75/files#diff-5 (86)
- M master/llvmjl.py https://github.com/JuliaCI/julia-buildbot/pull/75/files#diff-6 (3)
- M master/master.cfg https://github.com/JuliaCI/julia-buildbot/pull/75/files#diff-7 (16)
- D master/nightly_separated_testing.py https://github.com/JuliaCI/julia-buildbot/pull/75/files#diff-8 (64)
- M master/package.py https://github.com/JuliaCI/julia-buildbot/pull/75/files#diff-9 (37)
- D master/package_launchpad.py https://github.com/JuliaCI/julia-buildbot/pull/75/files#diff-10 (57)
- M master/run_code.py https://github.com/JuliaCI/julia-buildbot/pull/75/files#diff-11 (3)
Patch Links:
- https://github.com/JuliaCI/julia-buildbot/pull/75.patch
- https://github.com/JuliaCI/julia-buildbot/pull/75.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JuliaCI/julia-buildbot/pull/75, or mute the thread https://github.com/notifications/unsubscribe-auth/AAI3akHv_mKa0EglhBdIDyMX3oX2VZXpks5thFWpgaJpZM4S4DZU .
How........ how did you reply as an email to this change? Do you get an email every time I open a PR?
Presumably he follows the repo and receives email notifications for repos he follows.
I've merged this; let's keep an eye on the nightlies to make sure they are actually getting put up like we want them to be. :)
One thing that I was just wondering about how would one trigger a full build + test cycle? Just a forced build on the packager and the pipeline then works?
Yep that’s right. On Mon, Mar 26, 2018 at 23:55 Valentin Churavy notifications@github.com wrote:
One thing that I was just wondering about how would one trigger a full build + test cycle? Just a forced build on the packager and the pipeline then works?
— You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/JuliaCI/julia-buildbot/pull/75#issuecomment-376236066, or mute the thread https://github.com/notifications/unsubscribe-auth/AAH_aCWRkgwj6RCkNcMYtIVvdSCXu8P6ks5tiR2RgaJpZM4S4DZU .
--
-E
From this change onward,
package_
builders will only compile and bootstrap Julia; they will not run the tests. The compiled and boostrapped binaries are uploaded to AWS under thepretesting
namespace, and are then downloaded onto separatetester_
builders. If they pass testing within thetester_
builders, the binaries are then "promoted" frompretesting
to the actual download URLs.This provides a stronger guarantee of test suite correctness, as it isolates the build environment and the testing environment somewhat, and sets the stage for e.g. cross-compiling then running tests on the actual architectures.