JuliaCI / julia-buildbot

Buildbot configuration for build.julialang.org
MIT License
19 stars 14 forks source link

Add a release mode so those builds don't get pushed to nightlies #9

Closed tkelman closed 9 years ago

tkelman commented 9 years ago

Ref https://github.com/JuliaLang/julia/issues/9136

tkelman commented 9 years ago

apparently an if statement isn't working the way you want? https://github.com/JuliaLang/julia/issues/9136#issuecomment-64225474

which one?

staticfloat commented 9 years ago

I originally had a thing in to disable reporting to status.julialang.org if the scheduler that initiated the build was not the nightly builder. I had to remove it because it wasn't working properly. I'll try to put it in again, and see if things magically work better. There are more commits than I'm comfortable admitting in this repository trying to debug the stupid thing.

tkelman commented 9 years ago

Another minor related nit is the 0.3.3 binaries didn't seem to have the "Official http://julialang.org/ build" in the banner.

At what point do we promote the buildbot to build.julialang.org?

staticfloat commented 9 years ago

Anytime @StefanKarpinski wants to. :P Although, we should probably make build.julialang.org a CNAME pointing at buildbot.e.ip.saba.us, since the IP will change every time I destroy the instance and recreate it.

The OSX build definitely has the banner, (although it has extraneous quotes) the windows builds must be dropping it somehow.

staticfloat commented 9 years ago

Alright, I consolidated the flags somewhat to make things a little more organized. Windows and Linux tarballs should get the banner now.

staticfloat commented 9 years ago

I've got another try for not reporting to status.julialang.org up, let's see if it works.

staticfloat commented 9 years ago

Okay, so it skipped it properly. Now the question is, will it NOT skip it when an actual nightly goes through...

staticfloat commented 9 years ago

Huzzah! It's working!