search

JuliaCI / julia-buildkite

Buildkite configuration files for Base Julia CI
8 stars 15 forks source link

mark revise and gcext as not soft failable #394

Closed KristofferC closed 1 month ago

KristofferC commented 1 month ago

Too easy to miss these and merge breaking code otherwise.

giordano commented 1 month ago

Partial duplicate of #393 (which is waiting on https://github.com/timholy/Revise.jl/pull/856 to fix revise)

DilumAluthge commented 1 month ago

After https://github.com/timholy/Revise.jl/pull/856 is merged, do we also need to wait for a new release of Revise to be registered?

Or does test-revise run on Revise#master?

KristofferC commented 1 month ago

Master it seems:

https://github.com/JuliaCI/julia-buildkite/blob/4821ba2a04c24c578f20faf98c427e189f450bfa/pipelines/main/misc/test_revise.yml#L33

topolarity commented 1 month ago

Any reason for closing?

KristofferC commented 1 month ago

I didn't see https://github.com/JuliaCI/julia-buildkite/pull/393 got closed.