search

JuliaCI / sandboxed-buildkite-agent

2 stars 0 forks source link

macOS: Upgrade breaks workers #84

Closed maleadt closed 2 weeks ago

maleadt commented 1 month ago

I recently tried upgrading our workers from d16087d9f1fa9280cd605fb2944a5711ad4fd3c5 to current master, in order to include https://github.com/JuliaCI/sandboxed-buildkite-agent/pull/59, but that triggers several issues, including:

2024-09-23 05:43:01 WARN   The git-mirrors experiment has been promoted to a stable feature in agent version v3.47.0. You can safely remove the `--experiment git-mirrors` flag to silence this message and continue using the feature
2024-09-23 05:43:01 WARN   Unknown experiment "output-redactor"
2024-09-23 05:43:01 WARN   The ansi-timestamps experiment has been promoted to a stable feature in agent version v3.48.0. You can safely remove the `--experiment ansi-timestamps` flag to silence this message and continue using the feature
Job API
Running global environment hook
Preparing plugins
Preparing working directory
Running plugin external-buildkite post-checkout hook
$ /private/var/tmp/agent-tempdirs/default-grannysmith-C07ZQ07FJYVY.0/home/.buildkite-agent/plugins/github-com-JuliaCI-external-buildkite-buildkite-plugin-v1/hooks/post-checkout
2024-09-23 05:43:08 WARN   The git-mirrors experiment has been promoted to a stable feature in agent version v3.47.0. You can safely remove the `--experiment git-mirrors` flag to silence this message and continue using the feature
2024-09-23 05:43:08 WARN   Unknown experiment "output-redactor"
2024-09-23 05:43:08 WARN   The ansi-timestamps experiment has been promoted to a stable feature in agent version v3.48.0. You can safely remove the `--experiment ansi-timestamps` flag to silence this message and continue using the feature
/private/var/tmp/agent-tempdirs/default-grannysmith-C07ZQ07FJYVY.0/home/.buildkite-agent/plugins/github-com-JuliaCI-external-buildkite-buildkite-plugin-v1/lib/common.sh: line 90: conditional binary operator expected
🚨 Error: The plugin external-buildkite post-checkout hook exited with status 2
# Successfully shut down Job API server

So this is now failing: https://github.com/JuliaCI/external-buildkite-buildkite-plugin/blob/bfdf82ea6902bbcadb5ffd8281f952fc1bd274f9/lib/common.sh#L90-L93

In order to restore CI I've reverted the upgrade, but we may want to look into this.

maleadt commented 1 month ago

@IanButterworth also notes that the Unknown experiment "output-redactor" may be a security issue, and should be looked into when upgrading.

maleadt commented 2 weeks ago

Looks like Elliot disabled most of these experiments in #72, so I take it we don't need them.