search

JuliaCN / julia_zh_cn

已废弃，请到JuliaZH.jl参与翻译
https://github.com/JuliaCN/JuliaZH.jl
223 stars 81 forks source link

translated several paragraphs in embedding.rst #43

Closed XD-DENG closed 9 years ago

XD-DENG commented 9 years ago

Translated several paragraphs in embedding.rst

This is also my first try on Julia documentation translation. I'm trying to find a way to contribute to julia.

Many thanks

XD-DENG commented 9 years ago

Added space as you kindly indicated.

This is my first time to commit to this project. Only three paragraphs. Please understand as I'm trying to get familiar with the work flow of this project. Thanks.

(Chinese input method on my laptop is not working well, so I comment in English. Sorry for this)

yuyichao commented 9 years ago

LGTM. I'll give others some time to comment and will merge a few hours later otherwise.

GaZ3ll3 commented 9 years ago

good to merge. and one more thing, if possible, please rebase and squash the commits into one commit, if not, still we can merge it.

We really need to make some rules/instructions on committing.

XD-DENG commented 9 years ago

@GaZ3ll3 Hi, thanks for suggesting. I'm not so familiar with the rebase and squash feature. May you merge it firstly? and I'll learn about these features later and apply next time. Fully understand that we need rules on committing to ensure that whole project goes well.

yuyichao commented 9 years ago

Rebased manually and pushed.

yuyichao commented 9 years ago

@XD-DENG See https://help.github.com/articles/about-git-rebase/ and the related links for rebase and squash.

XD-DENG commented 9 years ago

@yuyichao Many thanks.