search

JuliaClimate / CDSAPI.jl

Julia API to the Climate Data Store (a.k.a. CDS)
https://cds.climate.copernicus.eu
MIT License
23 stars 6 forks source link

Bugs in CDSAPI.retrieve #20

Closed LakshyaKhatri closed 4 years ago

LakshyaKhatri commented 4 years ago

In #15, I pushed some bugs by mistake due to which retrieve stopped working. Kindly merge/provide feedback #19 and #18 so that I can do a rebase and push the corrections

juliohm commented 4 years ago

Thank you for checking. I'll do it soon. Finishing breakfast in BRT time. :)

On Wed, Jul 1, 2020, 08:45 Lakshya Khatri notifications@github.com wrote:

In #15 https://github.com/JuliaClimate/CDSAPI.jl/pull/15, I pushed some bugs by mistake due to which retrieve stopped working. Kindly merge/provide feedback #19 https://github.com/JuliaClimate/CDSAPI.jl/pull/19 and #18 https://github.com/JuliaClimate/CDSAPI.jl/pull/18 so that I can do a rebase and push the corrections

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JuliaClimate/CDSAPI.jl/issues/20, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZQW3LYYDMMU6H7ROIJQFDRZMOW5ANCNFSM4ONKQUWA .

juliohm commented 4 years ago

I've merged #19 and can merge #18 as soon as you fix the TAB issue we described there. It would be really nice if we could address #12 before moving forward.

LakshyaKhatri commented 4 years ago

I was working on the test cases when I noticed this. Unfortunately this needs to be fixed so that I can write tests for it.