JuliaClimate / CDSAPI.jl

Julia API to the Climate Data Store (a.k.a. CDS)
https://cds.climate.copernicus.eu
MIT License
23 stars 6 forks source link

Fix build on GitHub Actions #46

Open juliohm opened 2 years ago

juliohm commented 2 years ago

Hi @LakshyaKhatri, hope you are doing well.

In an attempt to port the Travis build to GitHub Actions I realized too late that you had added custom instructions in Travis to authenticate remotely with CDSAPI:

before_install:
- openssl aes-256-cbc -K $encrypted_fbf94d2678c4_key -iv $encrypted_fbf94d2678c4_iv
  -in .cdsapirc.enc -out $HOME\/.cdsapirc -d

Could you please help adding these instructions to our new CI.yml workflow? I also accidentally deleted the .cdsapirc.enc file you added to the repository. Please feel free to revive it if necessary.

LakshyaKhatri commented 2 years ago

Hey! Hi @juliohm ! Sorry for a late response. Sure, I'll take a look at it on my end

juliohm commented 2 years ago

Thank you @LakshyaKhatri ! Appreciate it! Looking forward to the fix ❀️

LakshyaKhatri commented 2 years ago

Hi @juliohm, I will need a little help on this. I was thinking to change the auth process this way:

  1. Add the auth instructions to github environment variables
  2. Now, before running the test suite we can create a .cdsapirc file on the fly using the details in the environment variables (and delete it in a finalization process).

That way we will not be maintaining a .cdsapirc.enc file on our repository. πŸ˜ΈπŸ’‘ Or we can do it the old way i.e. add an encrypted version of .cdsapirc in our repo and decrypt it in the CI.

What do you suggest?

LakshyaKhatri commented 2 years ago

Ah! nvm, I just learned we have to store env variable values in the CI file itself πŸ˜Άβ€πŸŒ«οΈ

juliohm commented 2 years ago

Thank you for taking a look into it. Any method that works and is safe should be fine.

Em dom., 31 de jul. de 2022 03:44, Lakshya Khatri @.***> escreveu:

Ah! nvm, I just learned we have to store env variable values in the CI file itself πŸ˜Άβ€πŸŒ«οΈ

β€” Reply to this email directly, view it on GitHub https://github.com/JuliaClimate/CDSAPI.jl/issues/46#issuecomment-1200360985, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZQW3J3WXSPQGFK6SPCK6DVWYOFTANCNFSM54TPJOHQ . You are receiving this because you were mentioned.Message ID: @.***>

juliohm commented 2 years ago

The build is failing on Windows now because GRIB.jl does not support the platform.

juliohm commented 2 years ago

Opened an issue there: https://github.com/weech/GRIB.jl/issues/14

LakshyaKhatri commented 2 years ago

Wondering if I should propose a PR to GRIB.jl. I'll try my hands on it once 🀞🏽

juliohm commented 2 years ago

If you have the time and knowledge to fix it, please feel free to contribute a fix ❀️

juliohm commented 1 year ago

@LakshyaKhatri did you have a chance to take a look into this?

LakshyaKhatri commented 1 year ago

Hi @juliohm, πŸ‘‹πŸ½

I was still waiting for a response on GRIB.jl from the maintainer. But I will take GRIB.jl issue and work on it (after the vacation season though πŸ™‚)