JuliaClimate / CDSAPI.jl

Julia API to the Climate Data Store (a.k.a. CDS)
https://cds.climate.copernicus.eu
MIT License
23 stars 6 forks source link

investigate failing test suite #50

Closed haakon-e closed 1 year ago

haakon-e commented 1 year ago

In reality this PR checks that CI succeeds with no code changes, since #49 fails.

haakon-e commented 1 year ago

ah, it appears the jobs weren't triggered in this PR. cc: @LakshyaKhatri

juliohm commented 1 year ago

@haakon-e this PR simply adds a dot to the docstring. Am I missing something?

haakon-e commented 1 year ago

yeah, so the point is to prove that the change in #49 isn't the cause of failing tests.

This leads me to suspect that either a patch release in one of the dependencies is causing tests to fail (compared to successful tests on master 3 weeks ago), or there is an issue with the CDS API outside of the Julia ecosystem.

haakon-e commented 1 year ago

updated the PR title to make this clearer.

haakon-e commented 1 year ago

Looking at the stacktrace:

ERA5 monthly preasure data: Error During Test at /Users/runner/work/CDSAPI.jl/CDSAPI.jl/test/retrieve.jl:4
[165](https://github.com/JuliaClimate/CDSAPI.jl/actions/runs/3857660781/jobs/6575325258#step:7:168)
  Got exception outside of a @test
[166](https://github.com/JuliaClimate/CDSAPI.jl/actions/runs/3857660781/jobs/6575325258#step:7:169)
  BoundsError: attempt to access 1-element Vector{SubString{String}} at index [2]
[167](https://github.com/JuliaClimate/CDSAPI.jl/actions/runs/3857660781/jobs/6575325258#step:7:170)
  Stacktrace:
[...]

it seems like something happens when datasets are downloaded. Are you able to check this out locally to see where/why the BoundsError is occurring?

juliohm commented 1 year ago

I mean, we know already that the build is failing due to GRIB support on Windows: https://github.com/JuliaClimate/CDSAPI.jl/issues/46

LakshyaKhatri commented 1 year ago

@juliohm the tests seem to be failing for other platforms as well, this couldn't be the GRIB issue 🤔

haakon-e commented 1 year ago

Yeah, the stacktrace I was quoting above was on macos.