search

JuliaCollections / DataStructures.jl

Julia implementation of Data structures
https://juliacollections.github.io/DataStructures.jl/latest/
MIT License
692 stars 247 forks source link

Implementation of Pairing heaps and Fibonacci heaps. #500

Open sinhatushar opened 5 years ago

sinhatushar commented 5 years ago

I am working on a project which requires use of pairing heaps and fibonacci heaps. These are not yet implemented in DataStructures.jl . I will write my own Julia implementation of these heaps as they are important for my project. I can contribute them to DataStructures.jl by implementing FibonacciHeap <: AbstractHeap and PairingHeap <: AbstractHeap . Are these implementation of any interest to DataStructures.jl ?

kmsquire commented 5 years ago

It sounds interesting, but (as you can tell by the response time), there is a dearth of people to actually review such code. I would encourage you to create a separate package for now, perhaps trying to use the AbstractHeap interface so you have a drop-in replacement for users of that interface.

simonschoelly commented 5 years ago

These heaps are part of Tushar's Jsoc project for implementing the BlossomV algorithm, so I would be willing to review that code, so that the main developers here will not have too much work.

oxinabox commented 5 years ago

Yes, let's make it so.

drelatgithub commented 4 years ago

Is implementing pairing heaps / Fibonacci heaps still a thing? I think it would be very useful to have those available in this package. If there is no one doing this, I would like to help implementing one; if there's already an endeavor in another package, I'm wondering whether I can help port the implementation and create pull requests to this repo.

oxinabox commented 4 years ago

The package is not accepting new data structures until after we make it to 1.0. See #479 (you can help with that if you want. There is a checklist 🙂)