Closed KronosTheLate closed 5 months ago
Regarding your reviews, I though you were mainly changing my ecplixit conversion via Int(arg)
. But I had to add the lines in the first place to make it work. Have you tested your suggestions?
Have you tested your suggestions?
I have not. If you say they proved nesc then I will go with that. As my opinon is not strong
Do you need this backported to 0.18?
Fun fact: sometimes it's useful to use the Foo(n::Integer, args...) = Foo(Int(n), args...)
pattern even for constructors that perform automatic conversion. The reason? It confines specialization-diversity to a short "stub" function, and the "long function" (the one that does the actual work) gets compiled for a narrow range of types. I.e., less latency.
That said, here the constructors are short so I don't think it's a big deal either way.
Do you need this backported to 0.18?
If you are asking me, then no ^_^
This PR aims to solve https://github.com/JuliaCollections/DataStructures.jl/issues/891, and check if this issue occurs for other types as well. For the types listed [in the documentation](), the results are seen in the drop-down below.