search

JuliaCollections / DataStructures.jl

Julia implementation of Data structures
https://juliacollections.github.io/DataStructures.jl/latest/
MIT License
679 stars 242 forks source link

Use `Base._unsetindex!` in `pop!` and `popfirst!` #897

Closed kpamnany closed 4 months ago

kpamnany commented 4 months ago

For Deque and CircularDeque. So that popped elements are not rooted by the deque and can be GCed when they drop out of caller scope.

Completes the fix of #884.

oxinabox commented 4 months ago

@nickrobinson251 I am still maintaining things here, but I am happy to hand this one over to you. Go to https://github.com/orgs/JuliaCollections/ to accept your invite back to the org.

Usual procedure once happy with it: merge it into master, and backport it into #0.18-release,

nickrobinson251 commented 4 months ago

Also i wonder if we could add a test for this? Something based on checking summarysize perhaps?