Backport deque memory fix

JuliaCollections / DataStructures.jl

Julia implementation of Data structures

https://juliacollections.github.io/DataStructures.jl/latest/

MIT License

689 stars 243 forks source link

Backport deque memory fix #898

Closed nickrobinson251 closed 7 months ago

nickrobinson251 commented 7 months ago

backport #897 to v0.18 (fixes #884)

cc @kpamnany

nickrobinson251 commented 7 months ago

lol the release-0.18 branch has different CI, and tests against Julia v1.10... which fails! (so that's a good catch)

https://github.com/JuliaCollections/DataStructures.jl/actions/runs/7977951656/job/21782026775?pr=898

nickrobinson251 commented 7 months ago

oooohhh, it's not Julia v1.10 is v1.0 that's failing!

nickrobinson251 commented 7 months ago

_unsetindex! isn't defined til v1.3

https://github.com/JuliaLang/julia/commit/6f5cefb1d231a267eb5e0aa46469c0ef53593e28

nickrobinson251 commented 7 months ago

i've done the lazy fix and just defined _unsertindex! as a no-op on Julia v1.0 - v1.2

if an alternative (like drop support for pre-v1.3) or a better fix (actually implement _unsetindex! for pre-v1.3) is preferred, please let me know (cc @oxinabox)