search

JuliaCollections / FunctionalCollections.jl

Functional and persistent data structures for Julia
MIT License
124 stars 34 forks source link

update to new Base.iterate protocol #43

Closed rdeits closed 6 years ago

rdeits commented 6 years ago

This also, somehow, fixes #41.

codecov-io commented 6 years ago

Codecov Report

Merging #43 into master will decrease coverage by 1.46%. The diff coverage is 97.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   96.78%   95.31%   -1.47%     
==========================================
  Files           7        7              
  Lines         280      299      +19     
==========================================
+ Hits          271      285      +14     
- Misses          9       14       +5
Impacted Files Coverage Δ
src/BitmappedVectorTrie.jl 91.25% <100%> (-4.7%) :arrow_down:
src/PersistentVector.jl 92.15% <100%> (-0.87%) :arrow_down:
src/PersistentList.jl 100% <100%> (ø) :arrow_up:
src/PersistentSet.jl 100% <100%> (ø) :arrow_up:
src/PersistentMap.jl 98.82% <100%> (+0.07%) :arrow_up:
src/PersistentQueue.jl 93.75% <75%> (-0.37%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 53d03cb...effb6f9. Read the comment docs.

rdeits commented 6 years ago

Ok, I've replaced endof with lastindex and added some tests to make sure those methods get run

ranjanan commented 6 years ago

Bump to merge

rdeits commented 6 years ago

can we get a new release tag now that this is in?