Closed c-p-murphy closed 6 years ago
Merging #49 into master will increase coverage by
0.07%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 95.31% 95.39% +0.07%
==========================================
Files 7 7
Lines 299 304 +5
==========================================
+ Hits 285 290 +5
Misses 14 14
Impacted Files | Coverage Δ | |
---|---|---|
src/PersistentList.jl | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6c3d004...89d4752. Read the comment docs.
Merging #49 into master will increase coverage by
0.07%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 95.31% 95.39% +0.07%
==========================================
Files 7 7
Lines 299 304 +5
==========================================
+ Hits 285 290 +5
Misses 14 14
Impacted Files | Coverage Δ | |
---|---|---|
src/PersistentList.jl | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6c3d004...89d4752. Read the comment docs.
Merging #49 into master will increase coverage by
0.07%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 95.31% 95.39% +0.07%
==========================================
Files 7 7
Lines 299 304 +5
==========================================
+ Hits 285 290 +5
Misses 14 14
Impacted Files | Coverage Δ | |
---|---|---|
src/PersistentList.jl | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6c3d004...89d4752. Read the comment docs.
Merging #49 into master will increase coverage by
0.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 95.31% 95.33% +0.01%
==========================================
Files 7 7
Lines 299 300 +1
==========================================
+ Hits 285 286 +1
Misses 14 14
Impacted Files | Coverage Δ | |
---|---|---|
src/PersistentList.jl | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6c3d004...32d0913. Read the comment docs.
Why did you close this?
I hadn't heard anything so I figured there wasn't any interest. I can reopen it if it would be useful.
I think most maintainers of this package have been busy with other things recently, so haven't been able to review. I took a quick look at it seems reasonable. I would perhaps consider writing this recursively like it is done for map
; do you have a reason (e.g. stack issues) for writing it this way?
Okay. I went ahead and implemented it recursively.
Awesome, thanks!
Thought this might be a useful addition.