Codecov Report

Merging #23 into master will decrease coverage by 5.57%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   93.36%   87.79%   -5.58%     
==========================================
  Files           2        2              
  Lines         392      295      -97     
==========================================
- Hits          366      259     -107     
- Misses         26       36      +10

Impacted Files	Coverage Δ
src/IterTools.jl	`87.58% <100%> (-5.7%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5fe5f2b...55b4f7d. Read the comment docs.

ararslan commented 6 years ago

Could do with a deprecation

iamed2 commented 6 years ago

Alright, should be easy enough to deprecate to the same thing without the macro.

iamed2 commented 6 years ago

I deprecated in a separate commit so we can just revert it later to kill the deprecation.

iamed2 commented 6 years ago

Rebased. @ararslan deprecation look good?

ararslan commented 6 years ago

Looks like @take and others were also removed with deprecation. Was that intended or were they caught in the crossfire?

iamed2 commented 6 years ago

They were never exported so I removed them without deprecation. Essentially @itr would internally dispatch to the appropriate macro based on the iterator function you were calling.

ararslan commented 6 years ago

Oh, gotcha. I'm fine with whatever, so if you're satisfied with this PR then I am too. 🙂 The deprecation looks good to me.

iamed2 commented 6 years ago

Woo! 0.7 test success here we come!

JuliaCollections / IterTools.jl

Remove the itr macro #23

Codecov Report