search

JuliaCollections / IterTools.jl

Common functional iterator patterns
Other
154 stars 29 forks source link

Added takewhile #54

Closed reinermartin closed 5 years ago

reinermartin commented 5 years ago

Added a takewhile function as discussed in issue "Would takewhile be a natural candidate for IterTools.jl?"

ararslan commented 5 years ago

The test failures should be fixed by simply adding takewhile to the list of exports.

reinermartin commented 5 years ago

The test failures should be fixed by simply adding takewhile to the list of exports.

Thanks, done that as well now

codecov-io commented 5 years ago

Codecov Report

Merging #54 into master will increase coverage by 0.22%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   75.23%   75.46%   +0.22%     
==========================================
  Files           1        1              
  Lines         210      216       +6     
==========================================
+ Hits          158      163       +5     
- Misses         52       53       +1
Impacted Files Coverage Δ
src/IterTools.jl 75.46% <83.33%> (+0.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64a14a8...16699ee. Read the comment docs.

ararslan commented 5 years ago

Great work here!

reinermartin commented 5 years ago

Great work here!

Thanks for your help!

reinermartin commented 5 years ago

iamed2, all your suggestion should be implemented, plus I fixed a bug (when condition was always true for a finite iterator it failed, I added @something to fix this)

iamed2 commented 5 years ago

Lovely, thanks! I'll give #46 another look tomorrow and then I think I'll make a release.